Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hour is printing but issue with min part; also need more efficient … #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hour is printing but issue with min part; also need more efficient … #22

wants to merge 1 commit into from

Conversation

Gabba42
Copy link

@Gabba42 Gabba42 commented Dec 4, 2017

…way to setup maps....

thesleuth
thesleuth reviewed Dec 4, 2017
View reviewed changes
Copy link

@thesleuth thesleuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a start in the right direction. You may want to break up the conversion by hours and minutes ot make it easier to repurpose the number to string indexing. Good choice on the collections use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesleuth thesleuth thesleuth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabba42 @thesleuth