-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new directory to be saved by zmdiaglog introduced into zimbra 8… #9
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong.
@@ -607,6 +607,7 @@ sub run() { | |||
my @network_conf_files = ( | |||
"/opt/zimbra/conf/zextras/config", | |||
"/opt/zimbra/conf/zextras/oplog", | |||
"/opt/zimbra/conf/zextras/bulk_delete/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what we would typically find under here, but if we're trying to get files under bulk_delete, then we need to use glob()
similar to two lines below.
Also, unrelated, but curious... why is a log (oplog
) living under /opt/zimbra/conf (and /opt/zimbra/conf/zextras/data/
too)? Logs/data files are typically under /var/log or /opt/zimbra/log or /opt/zimbra/data, but not under config. Sigh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DinoPuller can you please address review comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plobbes The files in the /opt/zimrba/conf/zextras/* are controlled by zxtras. They are separate because they are not part of the core zimbra product. I don't like it either, but that's where they are.
bulk_delete contains a json file with a list of message ids that zextras will delete based on a sweeper process. The sweeper will read the file then delete those blobs. this is how they prevent stale blobs from being in the store, and also prevent large delete requests from impacting the server.
We could ask them to move the files, no problem with that. but the files added by @DinoPuller could be useful, as we had a case today where I needed them.
If you can, anything recursively in the /opt/zimbra/conf/zextras dir would be incredibly useful for zmdialog.
Added new directory to be saved by zmdiaglog introduced into zimbra 8.8.7 NG