Improve existing full block benchmark #2168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | improve-bench |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 803.02 | |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8.48 (-7.30%) | 10.41 (81.43%) |
JamesHinshelwood
force-pushed
the
improve-bench
branch
from
0d234c8 to
82657b4
Compare
JamesHinshelwood
force-pushed
the
improve-bench
branch
from
82657b4 to
fb42eb0
Compare
Previously we would generate pre-emptively generate 3.2 million transactions, just in case we ran enough iterations to need them. Instead, we use Criterion's `iter_batched` method to generate the transactions as they are needed. This ensures we don't generate more transactions than we need and that we don't consume loads of memory. The two downsides of this approach are: * We don't generate transactions in parallel any more, but this doesn't seem to make much difference to the total benchmarking time now that we aren't over-generating transactions. * The generated flamegraphs now include the transaction generation calls, but drilling down and ignoring them is only one keypress. I've also renamed the benchmark from `produce-full` to `full-blocks-evm-transfers` since I think it better represents what we are testing.
JamesHinshelwood
force-pushed
the
improve-bench
branch
from
fb42eb0 to
2b984d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would generate pre-emptively generate 3.2 million transactions, just in case we ran enough iterations to need them. Instead, we use Criterion's
iter_batchedmethod to generate the transactions as they are needed. This ensures we don't generate more transactions than we need and that we don't consume loads of memory. The two downsides of this approach are:I've also renamed the benchmark from
produce-fulltofull-blocks-evm-transferssince I think it better represents what we are testing.