Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all-in-one pairwise alignment wrapper #650

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trivoldus28
Copy link
Contributor

@trivoldus28 trivoldus28 commented Feb 22, 2024

Example CUE that I actually used provided. Generally ready for review, except mypy and I'm not sure if it's worth it? For the event of excluding it from mypy, I wasn't sure if there's a option to do that or to move the file to internal.

Also looking for feedback on how things can be different for usability. In the example, the idea is that to adapt to different project the user only has to modify the first 150 lines. Everything else (like manipulating paths) should be as automated as possible to remove fluffs and improve readability.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9295d11) to head (c1f2663).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          128       128           
  Lines         4572      4527   -45     
=========================================
- Hits          4572      4527   -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trivoldus28 trivoldus28 marked this pull request as draft May 10, 2024 15:41
@trivoldus28
Copy link
Contributor Author

Since it's likely to need significant work to get it pass tests, I'll make it draft for now and revisit it later next time I use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant