Encoder training: new regimes and specs #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nkemnitz
commented
Sep 5, 2023
•
nkemnitz
commented
- includes / requires feat: imgaug library support #446
- includes / requires Support mapping as input for most tensor ops #498
- includes / requires fix/feat(lightning_train_remote): accept dict / PartialBuilder spec #513
- includes / requires feat: preserve tuples in JSON #514
- requires fix(convblock): skip connection beyond last convolution with post-act… #537
nkemnitz
force-pushed
the
nkem/train-encoder
branch
3 times, most recently
from
315a580
to
38418b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 128 129 +1
Lines 4284 4301 +17
=========================================
+ Hits 4284 4301 +17 ☔ View full report in Codecov by Sentry. |
nkemnitz
force-pushed
the
nkem/train-encoder
branch
2 times, most recently
from
d124e82
to
541552e
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
6 times, most recently
from
42da668
to
01eb94f
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
3 times, most recently
from
ee4af7f
to
b563936
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
2 times, most recently
from
94aff8f
to
f03235b
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
3 times, most recently
from
281dceb
to
1d7a3eb
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
3 times, most recently
from
c1811a0
to
cc794e3
Compare
nkemnitz
changed the title
nkemnitz
force-pushed
the
nkem/train-encoder
branch
from
cc794e3
to
fff0522
Compare
supersergiy
requested changes
Nov 8, 2023
nkemnitz
force-pushed
the
nkem/train-encoder
branch
from
fff0522
to
f88e713
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
from
f88e713
to
de91eb8
Compare
supersergiy
force-pushed
the
nkem/train-encoder
branch
from
7701678
to
59b2491
Compare
nkemnitz
force-pushed
the
nkem/train-encoder
branch
5 times, most recently
from
55d3981
to
02e1e88
Compare
supersergiy
force-pushed
the
nkem/train-encoder
branch
from
02e1e88
to
46f534a
Compare
akhileshh
reviewed
Nov 28, 2023
| else builder.build(val_dataloader), | ||
| full_state_ckpt_path=full_state_ckpt_path, | ||
| ) | ||
| else: |
There was a problem hiding this comment.
there are no statements after the else so we can return and remove this block, one less level of indentation
akhileshh
reviewed
Nov 28, 2023
Comment on lines
299
to
310
| if train_args["trainer"]["accelerator"] == "gpu": | ||
| num_devices = int(resource_limits["nvidia.com/gpu"]) # type: ignore | ||
| trainer_devices = train_args["trainer"]["devices"] | ||
| if ( | ||
| isinstance(trainer_devices, int) | ||
| and trainer_devices != -1 | ||
| and trainer_devices != num_devices | ||
| ): | ||
| raise ValueError( | ||
| f"Trainer specification uses {trainer_devices} devices, " | ||
| f"while `nvidia.com/gpu` limit is {num_devices}." | ||
| ) |
There was a problem hiding this comment.
This check applies to num_nodes=1 as well, rest looks good
supersergiy
force-pushed
the
nkem/train-encoder
branch
from
25560c9
to
d8dda04
Compare
supersergiy
approved these changes
Nov 28, 2023
supersergiy
force-pushed
the
nkem/train-encoder
branch
from
8f0872a
to
eb16f5a
Compare
torms3
reviewed
Nov 30, 2023
| @@ -267,13 +293,31 @@ def _lightning_train_remote( | |||
| Creates a volume mount for `train.cue` in `/opt/zetta_utils/specs`. | |||
| Runs the command `zetta run specs/train.cue` on one or more worker pods. | |||
| """ | |||
| if train_args["trainer"]["accelerator"] == "gpu": | |||
There was a problem hiding this comment.
The [example DDP spec] sets accelerator to "cuda", resulting in a NotImplementedError.
supersergiy
added a commit
that referenced
this pull request
Feb 2, 2024
Encoder training: new regimes and specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.