Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some rounding related issues #451

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Fixing some rounding related issues #451

merged 5 commits into from
Aug 1, 2023

Conversation

nkemnitz
Copy link
Collaborator

2344e2b feels particularly ugly...

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #451 (16053c4) into main (a0845cb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          120       120           
  Lines         3586      3588    +2     
=========================================
+ Hits          3586      3588    +2     
Files Changed Coverage Δ
zetta_utils/geometry/bbox.py 100.00% <100.00%> (ø)
zetta_utils/geometry/vec.py 100.00% <100.00%> (ø)

Copy link
Member

@supersergiy supersergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!
Although some of this might not be particularly pretty, I do think it is the best we can do right now.

@supersergiy supersergiy merged commit 0bdda71 into main Aug 1, 2023
11 checks passed
@nkemnitz nkemnitz deleted the nkem/fix-rounding branch August 1, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants