Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typing for untyped defs #449

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: fix typing for untyped defs #449

merged 1 commit into from
Jul 28, 2023

Conversation

dodamih
Copy link
Collaborator

@dodamih dodamih commented Jul 24, 2023

No description provided.

@dodamih dodamih linked an issue Jul 24, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #449 (6bb3309) into main (c306552) will not change coverage.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 6bb3309 differs from pull request most recent head ea9a241. Consider uploading reports for the commit ea9a241 to get more accurate results

@@            Coverage Diff            @@
##              main      #449   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          120       120           
  Lines         3584      3585    +1     
=========================================
+ Hits          3584      3585    +1     
Files Changed Coverage Δ
zetta_utils/layer/volumetric/layer_set/layer.py 100.00% <ø> (ø)
zetta_utils/parsing/ngl_state.py 100.00% <ø> (ø)
zetta_utils/tensor_ops/mask.py 100.00% <ø> (ø)
zetta_utils/builder/build.py 100.00% <100.00%> (ø)
zetta_utils/builder/built_in_registrations.py 100.00% <100.00%> (ø)
zetta_utils/geometry/vec.py 100.00% <100.00%> (ø)
zetta_utils/tensor_ops/transform.py 100.00% <100.00%> (ø)
zetta_utils/training/datasets/layer_dataset.py 100.00% <100.00%> (ø)

@dodamih dodamih requested a review from supersergiy July 24, 2023 22:42
@dodamih
Copy link
Collaborator Author

dodamih commented Jul 24, 2023

Most of the type: ignore that are left are torchfields and docker not being typed.

@dodamih dodamih force-pushed the dodam/typing branch 4 times, most recently from fffb80d to c9cf1d5 Compare July 25, 2023 13:05
Copy link
Member

@supersergiy supersergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@supersergiy supersergiy merged commit 6dd063b into main Jul 28, 2023
11 checks passed
@supersergiy supersergiy deleted the dodam/typing branch August 1, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set check_untyped_defs = true in pyproject.toml
3 participants