-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kornia binary morph ops #428
Conversation
@supersergiy Do you want tests here or is that more of a delegation thing? |
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 120 120
Lines 3588 3618 +30
=========================================
+ Hits 3588 3618 +30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really cool!
Although the new functions don't have if
/for
statements, they're reasonably complex and would benefit from testing. The upside is that because there's no if
's, each function will need only a single test case to be fully covered.
Re deprecation:
The kornia_closing
requires kernel to be passed in explicitly, while the "custom" binary_closing
just assumes something reasonable. The explicit kernel is useful in some scenarios, but making it a required argument will make it a hassle a lot of the time. I think ideally we'd make the kernel an optional argument, which would let us deprecate the non-kornia alternatives.
Also, the kernerl
argument should probably be typed, unless there's something I'm missing.
39bc60a
to
7596599
Compare
7596599
to
a7294c1
Compare
a7294c1
to
6862cc9
Compare
Set default kernel to square footprint of width=3, removed unnecessary conversion to floating point, added documentation |
6862cc9
to
83ff8c7
Compare
83ff8c7
to
9e73171
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's great that the kernel
typing is more precise now - Tensor
instead of TensorTypeVar
. Now that the new kornia based operations have width, should we deprecate the old coarsen
and dilation
too?
e47397e
to
0504805
Compare
…ls into nkem/feat-morph-kornia
8abe6a8
to
8b6a13f
Compare
Co-authored-by: Sergiy Popovych <[email protected]>
No description provided.