automod match_link fixes #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal0
force-pushed
the
matchlinks-fixes
branch
from
7be86bb
to
e0801b9
Compare
almeidx
requested changes
Dec 28, 2023
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
metal0
force-pushed
the
matchlinks-fixes
branch
from
61ab401
to
d4c591b
Compare
metal0
force-pushed
the
matchlinks-fixes
branch
2 times, most recently
from
89ae47c
to
d4c591b
Compare
almeidx
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ZDEV-64
Fixes ZDEV-66
Why is this impl so cringe?
turns out im lazy. also i didnt want to touch the regex itself because i dont want to deal with potential new bypasses originated due to changing it. and it's also tricky since a non-encoded url can probably have[]().and still be valid