Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default ban reason #420

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: default ban reason #420

wants to merge 5 commits into from

Conversation

iamshoXy
Copy link
Contributor

This adds a default ban reason, as no DM was sent before if no reason was specified.

The default reason can be changed through the option default_ban_reason

@cla-bot cla-bot bot added the cla-signed label Jul 29, 2023
almeidx
almeidx requested changes Sep 9, 2023
View reviewed changes
backend/src/plugins/ModActions/functions/banUserId.ts Outdated Show resolved Hide resolved
backend/src/plugins/ModActions/types.ts Outdated Show resolved Hide resolved
@almeidx
Copy link
Collaborator

almeidx commented Dec 28, 2023

After putting some more thought into this pull request, why limit this to just ban reasons? Why not add something like a default_reasons object and allow setting the default messages for kick, mute, ban, etc.?

@iamshoXy
Copy link
Contributor Author

After putting some more thought into this pull request, why limit this to just ban reasons? Why not add something like a default_reasons object and allow setting the default messages for kick, mute, ban, etc.?

I've added the said object, the only issue atm is that it's not a string in the docs and I don't know why

image

iamshoXy
iamshoXy commented Apr 19, 2024
View reviewed changes
backend/src/plugins/ModActions/types.ts
Comment on lines 28 to 30
mute: z.string(),
kick: z.string(),
ban: z.string(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of limiting the reason in formatReasonWithAttachments it might be better to do it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla-signed needs to be updated needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamshoXy @almeidx