Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TGA support and GPL palette export #94

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Add TGA support and GPL palette export #94

wants to merge 10 commits into from

Conversation

Midnoclose
Copy link
Collaborator

Adds TGA reading and writing, as well as a little program to export your palette as a GIMP palette file for external programs

xslendix
xslendix previously approved these changes Feb 18, 2023
View reviewed changes
Copy link
Collaborator

@xslendix xslendix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one doubt about something but other than that, LGTM. Did not test, just did a quick look around.

src/Demo/Graphics/ScreenCapture.ZC Show resolved Hide resolved
@Midnoclose
Copy link
Collaborator Author

Contributes progress towards #27
TGA is much closer the the Zeal device contexts internally than BMP is.

@y4my4my4m y4my4my4m self-requested a review February 25, 2023 21:35
y4my4my4m
y4my4my4m requested changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@y4my4my4m y4my4my4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good but I'd just fix the one part I mentioned.
Also, does this introduce any issues loading/saving palettes for the paletteeditor?

src/System/Gr/MakeGr.ZC Outdated Show resolved Hide resolved
@Midnoclose Midnoclose added the enhancement New feature or request label Feb 25, 2023
@Midnoclose Midnoclose marked this pull request as draft March 12, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y4my4my4m y4my4my4m Awaiting requested review from y4my4my4m

@xslendix xslendix Awaiting requested review from xslendix

@TempleProgramming TempleProgramming Awaiting requested review from TempleProgramming

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Midnoclose @y4my4my4m @xslendix