Skyblock refactoring + bug fixes + dep upgrade #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(deps-dev): bump ruff from 0.7.3 to 0.7.4
… properly, as well fixing non-proper sorted ranking because of level cap
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.7.4 to 0.8.0. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.7.4...0.8.0) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Re refacto sb
Refactoring of the skyblock ranking process
chore(deps-dev): bump ruff from 0.7.4 to 0.8.0
gylfirst
added
bug
Zalk0
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
This pull request includes several changes to improve the bug and feature request templates, update dependencies, and enhance the functionality of various commands and utilities in the project. The most important changes are summarized below:
Issue Templates Enhancements:
.github/ISSUE_TEMPLATE/bug.yaml: Added a new bug report template to streamline the process of reporting bugs..github/ISSUE_TEMPLATE/feature_request.yaml: Added a new feature request template to facilitate suggesting new ideas for the project.Dependency Updates:
.pre-commit-config.yaml: Updated theruff-pre-commithook version fromv0.7.3tov0.8.0.Command Enhancements:
chouette/commands/skyblock.py: Added a cooldown of 60 seconds to thelinkcommand to prevent abuse.chouette/commands_list.py: Enhanced error handling to log and notify users when commands are on cooldown.Utility Function Improvements:
chouette/utils/hypixel_data.py: Updated theexperience_to_levelfunction to include new slayer types and return overflow experience. [1] [2] [3]chouette/utils/ranking.py: Refactored ranking calculation and message formatting, including deep copying data and sorting skill averages. [1] [2] [3] [4] [5] [6] [7] [8]