-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to PC User Experience #45
Open
KojoZero
wants to merge
18
commits into
ZXY101:main
Choose a base branch
from
KojoZero:testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@KojoZero is attempting to deploy a commit to the zxy101's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for the PR, time is short but I'll take a proper look next week after the JLPT is over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PC UX Improvements
Added toggle to disable mouse panning
When using Yomitan, it's easy to accidentally move the page when clicking off, so I added a toggle to disable mouse panning.
Changed scrollwheel actions
The current settings for Mokuro are unnatural on PC. Scrollwheel has been changed to pan vertically, and zooming has been changed to Ctrl+Scrollwheel.
Added more Keyboard shortcuts
More keyboard shortcuts added such as: Turn page with 'A'/'D', Reset Zoom/Pan with 'R', and Toggle Cover with 'C'. These have been added to make navigation more efficient, especially if you're using Yomitan.
Fixed zoom settings
Currently, the zoom out amount is greater than the zoom in amount. This has been fixed so that they are now the same.
Added menu to see keyboard shortcuts
Currently, the keyboard shortcuts aren't listed anywhere on the reader, so I added a menu.