Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RLE and dictionary bugs #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix RLE and dictionary bugs #81

wants to merge 2 commits into from

Conversation

garyirick-rga
Copy link

This PR fixes 2 bugs:

  • RLE encoding and decoding does not work correctly if the dictionary has > 255 entries.
  • A column chunk with a dictionary and data pages in both PLAIN and PLAIN_DICTIONARY decodes the PLAN pages incorrectly.

There is no unit test for the second fix. I could only reproduce this with a 290 MB .parquet file generated by Apache Spark, and was unable to find another library that will create a file with both PLAIN and PLAIN_DICTIONARY pages in the same chunk.

This was referenced Apr 20, 2022
Open
Open
@wilwade wilwade mentioned this pull request Apr 27, 2022
Closed
@dopatraman dopatraman mentioned this pull request May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garyirick-rga