[Fix] ci: Use Unix paths for PyInstaller spec #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyInstaller claims that either Windows or Unix paths should work, and the old method of using Unix paths appeared to successfully generate working Windows binaries. I'm not sure why using Windows paths fails, though. For now, use Unix paths. If necessary, "os.path.join(...)" could be used instead. Partially reverts b91dfdf See https://pyinstaller.org/en/stable/spec-files.html And https://github.com/IldarRyabkov/BubbleTanks2/blob/main/src/setup.spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short
The strings may use either / or \ as the path separatorDetails
PyInstaller claims that either Windows or Unix paths should work, and the old method of using Unix paths appeared to successfully generate working Windows binaries. I'm not sure why using Windows paths fails, though.
For now, use Unix paths. If necessary,
os.path.join(...)could be used instead.One example is Bubble Tanks 2 which has a Windows build and yet it uses
/for path separators.