[Update] Switch to FreeSimpleGUI, update deps #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from PySimpleGUI to FreeSimpleGUI, avoiding the phone-home license checking and hassle of expecting everyone to register a hobbyist license key once a year. See https://www.reddit.com/r/Python/comments/1d8d4iv/psa_pysimplegui_has_deleted_almost_all_old_lgpl/ And https://github.com/spyoungtech/FreeSimpleGUI Updates to Py/FreeSimpleGUI now check for invalid updates to the GUI once a window is closed and pop up a dialog box instead of letting the exception occur as expected. Add a "shutting_down" check to stop text updates once closing the main window. See https://docs.pysimplegui.com/en/latest/cookbook/original/exception_handling/ Update other dependencies and switch to "latest compatible" versioning, allowing CI builds to test updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short
spyoungtechRationale
PySimpleGUI now costs $99 for a license key which cannot be shared (would require some central secret management), and now includes code to phone home, self-update, etc, which feels concerning.
Considering Haptic Pancake is fairly simple, just switch to FreeSimpleGUI instead. If we want more complex features (e.g. resizable windows with a smoother layout), I'd encourage using a "full" toolkit, such as Qt.
Breaking changes
Py/FreeSimpleGUI now checks for invalid updates to the GUI once a window is closed and pops up a dialog box instead of letting the exception occur as expected. There's a
shutting_downcheck to stop text updates once closing the main window, but that might not be everything.I would encourage testing this personally before making a release with this change.
See https://docs.pysimplegui.com/en/latest/cookbook/original/exception_handling/
Context