Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swap helpers. #1859

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Add swap helpers. #1859

merged 7 commits into from
Jun 4, 2024

Conversation

Salamandar
Copy link
Contributor

This provides yunohost 2 things:

  • Remove duplication and centralize code and bugfixes for easier maintainance
  • The day the core supports swap, or we want to change the logic, these helpers can be changed to empty shells.

The problem

swap helpers everywhere in the apps.

@tituspijean

This comment was marked as resolved.

Sign in to view
@Salamandar Salamandar mentioned this pull request May 31, 2024
Open
@Salamandar Salamandar changed the base branch from dev to swap May 31, 2024 14:33
@Salamandar Salamandar closed this May 31, 2024
@Salamandar Salamandar reopened this May 31, 2024
@tituspijean
Copy link
Contributor

Feel free to merge and work directly into #1859!

@Salamandar
Copy link
Contributor Author

Salamandar commented Jun 4, 2024 •
edited
Loading

I think you meant #1858 :)

@Salamandar Salamandar merged commit e039d2e into swap Jun 4, 2024
2 of 3 checks passed
@Salamandar Salamandar deleted the helper_swap branch June 4, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Salamandar @tituspijean