Lint Lua with luacheck #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salamandar
commented
Oct 24, 2024
Salamandar
commented
- to be verified, i don't really know lua
- not sure all that is relevant
- my IDE was giving me more errors than luacheck (deprecated stuff, "need to check nil", etc)
alexAubin
reviewed
Oct 24, 2024
Comment on lines
-76
to
+77
| local header, err = cjson_safe.decode(basexx.from_url64(segments[1])) | ||
| if err then | ||
| return nil, nil, nil, "Invalid header" | ||
| end | ||
|
|
||
| local body, err = cjson_safe.decode(basexx.from_url64(segments[2])) | ||
| if err then | ||
| return nil, nil, nil, "Invalid body" | ||
| end | ||
|
|
||
| local sig, err = basexx.from_url64(segments[3]) | ||
| if err then | ||
| return nil, nil, nil, "Invalid signature" | ||
| end | ||
|
|
||
| return header, body, sig | ||
| local segments = split_token(token) | ||
| if #segments ~= 3 then | ||
| return nil, nil, nil, "Invalid token" | ||
| end | ||
| local err, header, body, sig | ||
|
|
||
| header, err = cjson_safe.decode(basexx.from_url64(segments[1])) |
There was a problem hiding this comment.
This is gonna be confusing if we ever update this vendor lib because we're not the author of this ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.