V2

[Josue-T]

Problem

• Packaging v2 #401
• Attempting to log in only shows the CAS option, resulting in a loop #412
• update e2e config (config panel and nginx conf) #424 (not the best way to fix it...)
• Correct newline in config yaml lists with $'\n' #376 (still be buggy)
• Cannot change "Largest allowed media upload size in bytes." #422
• Missing quotes around value in /.well-known/matrix/client? #416
• Change the ssowat to fix a bug that prevents people from resetting their passwords #406
• Implement MSC1929 Implement MSC1929 #434

Solution

• Rework package with packaging v2 practice
• Rework config panel with settings instead of sed directly in config file

TODO

• Test email with system user (need Fix app mail - Add main domain into hosts file YunoHost/yunohost#1780 to work correctly)
• Manage issues with LDAP user vs system user -> should write a patch to fix Filter not respected. matrix-org/matrix-synapse-ldap3#169 to be able to remove the synapse yunohost user. -> Add support of ldap filter with anonymous user matrix-org/matrix-synapse-ldap3#186
• Standardize systemd unit name
• Write test.toml
• Test if we still need the SSO and password authentication in config panel
• Test config panel (need Add generales var in config panel like domain, path, etc YunoHost/yunohost#1772 and Use single quote to return value to config panel YunoHost/yunohost#1789 to work correctly and still have this issue Can't save new value on Config panel YunoHost/issues#2331)
• Manage upgrade from old version
• Update homeserver config template from upstream
• Test and fix issues
• Check for bookworm support

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Thatoo]

I tried to install it but it has failed : https://paste.yunohost.org/raw/uwetisotec

[Josue-T]

I tried to install it but it has failed : https://paste.yunohost.org/raw/uwetisotec

Well, as it's written, it's a draft, so it's not finished. 😉

[Thatoo]

• Install works now : happy v2!!!
• I could login : CAS works again
• but when I tried to change some settings, I got this error :

2023-11-15 21:28:33,296: DEBUG - + ynh_die '--message=Variable $data_dir wasn'\''t initialized when trying to replace __DATA_DIR__ in /etc/matrix-synapse/homeserver.yaml'
2023-11-15 21:28:33,390: WARNING - Variable $data_dir wasn't initialized when trying to replace __DATA_DIR__ in /etc/matrix-synapse/homeserver.yaml

https://paste.yunohost.org/raw/asuwowopuj

[csolisr]

* [ ]  but when I tried to change some settings, I got this error :

2023-11-15 21:28:33,296: DEBUG - + ynh_die '--message=Variable $data_dir wasn'\''t initialized when trying to replace __DATA_DIR__ in /etc/matrix-synapse/homeserver.yaml'
2023-11-15 21:28:33,390: WARNING - Variable $data_dir wasn't initialized when trying to replace __DATA_DIR__ in /etc/matrix-synapse/homeserver.yaml

Similar issue here - and it's even more complicated now, because I can't even force upgrading to the latest version:

sudo yunohost app upgrade synapse -u https://github.com/YunoHost-Apps/synapse_ynh/tree/v2 -F
Info: Now upgrading synapse...
Info: Creating a safety backup prior to the upgrade
Info: Collecting files to be backed up for synapse...
Warning: It's hightly recommended to make your backup when the service is stopped. Please stop synapse service with this command before to run the backup 'systemctl stop matrix-synapse.service'
Info: Declaring files to be backed up...
Warning: /var/cache/yunohost/app_tmp_work_dirs/app_1sckfx0q/scripts/backup: line 52: synapse_db_name: variable unassigned
Error: Could not back up synapse
Info: The operation 'Create a backup archive' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20231121-174305-backup_create' to get help
Error: Nothing to save

Is there some way of manually setting the synapse_db_name variable in YNH so I can upgrade?

[Josue-T]

Hello,

PLEASE, don't upgrade to this version. This PR is just for information but is NOT ready. There still be a lot of work before to release it !! It could eventually be tested but NOT on production.

[csolisr]

Hello,

PLEASE, don't upgrade to this version. This PR is just for information but is NOT ready. There still be a lot of work before to release it !! It could eventually be tested but NOT on production.

Yup, just noticed it the hard way. Guess I'll have to wipe and reinstall the stable version later.

[csolisr]

Oh and if you stubbornly tried this PR before it was baked, and now you're stuck on the update part like I did, you can try setting the uninitialized values by hand:

sudo yunohost app setting synapse synapse_db_name -v $(sudo yunohost app setting synapse db_name);
sudo yunohost app setting synapse data_path -v $(sudo yunohost app setting synapse data_dir);

[Josue-T]

!bookwormtestme

[yunohost-bot]

📚

[Josue-T]

!bookwormtestme

[yunohost-bot]

Living in the future, are we?

[Josue-T]

!testme

[yunohost-bot]

🚀

[Josue-T]

!testme !bookwormtestme

[yunohost-bot]

📚 🪱

[yunohost-bot]

🌻

[Lab-8916100448256]

This is supposed to fix issue #313 but it is not always working.
On my server, after making the change, the synapse-coturn service is still failing to start at boot time.
One way to fix the issue that I have tested and that is working is to add the parameter -L 0.0.0.0 to the ExecStart line, as in this commit on my fork of the app : Lab-8916100448256@d211419

[Josue-T]

Well are you really sure about that this parameter -L 0.0.0.0 will fix the issue ?

[Josue-T]

!testme !bookwormtestme

[yunohost-bot]

✌️

[yunohost-bot]

📚 🐛

[Josue-T]

Let's merge as we don't know when YunoHost/package_linter#136 will be merged.