self review fixes

Yubico · May 23, 2024 · ccf082f · ccf082f
1 parent d5f28f1
commit ccf082f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/AndroidDemo/src/main/java/com/yubico/yubikit/android/app/ui/piv/PivCertificateFragment.kt b/AndroidDemo/src/main/java/com/yubico/yubikit/android/app/ui/piv/PivCertificateFragment.kt
@@ -130,8 +130,6 @@ class PivCertificateFragment : Fragment() {
         binding.title.text = getString(requireArguments().getInt(ARG_TITLE))
         showCerts(false)
 
-        pivViewModel.certificates
-
         pivViewModel.certificates.observe(viewLifecycleOwner, Observer {
             it ?: return@Observer
             val cert = it.get(slot.value)

diff --git a/piv/src/main/java/com/yubico/yubikit/piv/jca/PivProvider.java b/piv/src/main/java/com/yubico/yubikit/piv/jca/PivProvider.java
@@ -88,13 +88,6 @@ public Object newInstance(Object constructorParameter) {
             }
         });
 
-        putService(new Service(this, "Signature", "X25519", PivEcSignatureSpi.Prehashed.class.getName(), null, x25519Attributes) {
-            @Override
-            public Object newInstance(Object constructorParameter) {
-                return new PivEcSignatureSpi.Prehashed(sessionRequester);
-            }
-        });
-
         putService(new Service(this, "KeyAgreement", "X25519", PivKeyAgreementSpi.class.getName(), null, x25519Attributes) {
             @Override
             public Object newInstance(Object constructorParameter) {

diff --git a/testing/src/main/java/com/yubico/yubikit/testing/piv/PivJcaSigningTests.java b/testing/src/main/java/com/yubico/yubikit/testing/piv/PivJcaSigningTests.java
@@ -178,7 +178,6 @@ public static void testSign(PivSession piv, KeyType keyType) throws NoSuchAlgori
 
                 break;
         }
-
     }
 
     public static byte[] testSign(KeyPair keyPair, String signatureAlgorithm, AlgorithmParameterSpec param) throws NoSuchAlgorithmException, InvalidAlgorithmParameterException, InvalidKeyException, SignatureException {