osx: handle report_callback() firing multiple times #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it might make sense to bump the copyright in hid_osx.c; otherwise LGTM |
One invocation of CFRunLoopRunInMode() may fire report_callback() multiple times. In such a case, the next call to fido_hid_read() may block for the full duration of the timeout. We can handle this by querying the (non-blocking) pipe for any readily available data on entering fido_hid_read() and fall back to executing the run loop if it was empty. Debugged with @elibon99 and @martelletto.
kongeo
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One invocation of
CFRunLoopRunInMode()may firereport_callback()multiple times. In such a case, the next call to
fido_hid_read()mayblock for the full duration of the timeout. We can handle this by
querying the (non-blocking) pipe for any readily available data on
entering
fido_hid_read()and fall back to executing the run loop if itwas empty.
Debugged with @elibon99 and @martelletto.
Resolves #763