Dark theme images for docs #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use svg color filter matrix from @jix to invert brightness for images when using dark theme. Co-authored-by: Jannis Harder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
#4385
Explain how this is achieved.
New
invert-helpercss class uses svg color filter matrix from @jix (via #4385 (comment)) to invert brightness for images when using dark theme.If applicable, please suggest to reviewers how they can test the change.
Make docs locally, check images in both light and dark mode, using both the forced light/dark mode selector and the auto mode with browser/OS selected light/dark mode.