Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

techmap: add dynamic cell type test #4365

Merged
merged 1 commit into from
May 3, 2024

Conversation

widlarizer
Copy link
Collaborator

Is this behavior expected? A foo of width 4 gets techmapped to something named LCU_10. I expected the WIDTH parameter to be inferred. Are port sizes allowed to be mismatched when techmapping?

@povik
Copy link
Member

povik commented May 2, 2024

I bet this is because you are missing a call to ‘wreduce’. I suggest you do ‘prep’ in between reading the input and techmapping.

@povik
Copy link
Member

povik commented May 2, 2024

Actually no, this has nothing to do with wreduce. The WIDTH won’t get inferred, it needs to be an explicit parameter value on the cell, otherwise the default takes effect.

@widlarizer
Copy link
Collaborator Author

Makes perfect sense, fixed

@widlarizer widlarizer requested a review from povik May 3, 2024 10:14
@povik povik changed the base branch from techmap-chtype to main May 3, 2024 11:41
@povik
Copy link
Member

povik commented May 3, 2024

I had to change the base branch since techmap-chtype I happened to already merge. Please rebase accordingly

Copy link
Member

@povik povik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs rebasing otherwise looks good

@widlarizer widlarizer merged commit 2631c7e into YosysHQ:main May 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants