Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for a multi-task property status database #262

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jix
Copy link
Member

@jix jix commented Feb 19, 2024

This adds initial support for an sqlite database that is shared across multiple tasks of a single SBY file and that can track the status of individual properties.

The amount of information tracked in the database is currently quite minimal and depends on the engine and options used. This can be incrementally extended in the future.

The ways in which the information in the database can be queries is even more limited for this initial version, consisting of a single '--status' option which lists all properties and their status.

@jix
Copy link
Member Author

jix commented Feb 19, 2024

It seems Jenkins is running the tests with an older sqlite version than the one we currently ship, causing it to fail with an SQL syntax error due to the older version not having support for a feature I am using (cc @mmicko). I can reproduce that locally if I use an older release, but not with the latest tabby release.

@KrystalDelusion
Copy link
Member

I am getting the same error using tabby-linux-x64-latest.tgz from the 5th of Feb (so I guess the 20240118 build?). Are you using the experimental build with Python3.11 @jix ?

@mmicko
Copy link
Member

mmicko commented Feb 20, 2024

@jix CI machine is Ubuntu 20.04 based, so sqlite is bit older. Since it works with oss-cad-suite it should also work with latest tabbycad ( so maybe @KrystalDelusion is using older one). Maybe it is better to update according to change suggestion from @KrystalDelusion. We need to update CI machine, but it is risky.

This adds initial support for an sqlite database that is shared across
multiple tasks of a single SBY file and that can track the status of
individual properties.

The amount of information tracked in the database is currently quite
minimal and depends on the engine and options used. This can be
incrementally extended in the future.

The ways in which the information in the database can be queries is even
more limited for this initial version, consisting of a single '--status'
option which lists all properties and their status.
@jix jix merged commit 52184e5 into YosysHQ:master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants