Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set internal replication factors to match default and min.insync.replicas #140

Merged
merged 9 commits into from
Feb 3, 2018
Merged

Set internal replication factors to match default and min.insync.replicas #140

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aa2f557
Uses brokers' default replication factor for explicit topic creation
solsson Jan 22, 2018
e78f1c5
Should be larger than or equal min.insync.replicas
solsson Feb 1, 2018
321189a
Reverts previous commit and uses the documented default instead
solsson Feb 1, 2018
a95da87
Merge branch 'use-default-replication-factor' into fix-offset-topic-r…
solsson Feb 1, 2018
7017fc0
These properties have good defaults, 3 and 2 respectively,
solsson Feb 2, 2018
e5046b1
Updates the basic kafkacat test to use a consumer group of size 1
solsson Feb 2, 2018
e784bca
Adds a console based way to check for topics configured with 1 replica
solsson Feb 2, 2018
dc7734a
Removes outdated comment; these tests can't grow more complex
solsson Feb 2, 2018
77cdb36
Bumps kafka-manager to 1.3.3.16
solsson Feb 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/10broker-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ data:
############################# Internal Topic Settings #############################
# The replication factor for the group metadata internal topics "__consumer_offsets" and "__transaction_state"
# For anything other than development testing, a value greater than 1 is recommended for to ensure availability such as 3.
offsets.topic.replication.factor=1
#offsets.topic.replication.factor=1
transaction.state.log.replication.factor=1
transaction.state.log.min.isr=1

Expand Down
2 changes: 0 additions & 2 deletions kafka/test/kafkacat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ spec:
- test-kafkacat
- --partitions
- "1"
- --replication-factor
- "2"
restartPolicy: Never
---
apiVersion: apps/v1beta2
Expand Down
2 changes: 0 additions & 2 deletions kafka/test/produce-consume.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ spec:
- test-produce-consume
- --partitions
- "1"
- --replication-factor
- "2"
restartPolicy: Never
---
apiVersion: apps/v1beta2
Expand Down