Skip to content

Commit

Permalink
There's no reason to ever recommend auto.create.topics=true
Browse files Browse the repository at this point in the history
I though that the feature would be neat for development (with replication factor 1, see #222)
but it causes just as much confusion and useless troubleshooting there,
for example race conditions between intentional topic creation and a container
starting up to produce to the topic. You actually never know which topic config you're getting.

Related: #107

The duplication is a workaround for kubernetes-sigs/kustomize#642
  • Loading branch information
solsson committed Oct 8, 2019
1 parent 527aa0d commit 4c389e7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions variants/dev-small/auto-create-topics.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "advertised.listeners=PLAINTEXT://:9092,OUTSIDE://localhost:9094"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "auto.create.topics.enable=true"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "num.partitions=1"}
]
2 changes: 0 additions & 2 deletions variants/dev-small/listener-localhost.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "advertised.listeners=PLAINTEXT://:9092,OUTSIDE://localhost:9094"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "auto.create.topics.enable=true"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"},
{"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "num.partitions=1"}
]

0 comments on commit 4c389e7

Please sign in to comment.