Skip to content

Commit

Permalink
Reverts to default termination period, and uses bash for "shell form"...
Browse files Browse the repository at this point in the history
as Alpine's /bin/busybox (ash) does not forward signals, according to
https://pracucci.com/graceful-shutdown-of-kubernetes-pods.html

The reason for the termination period change is that we haven't observed
any termination behavior yet so we can't know how slow it might be.
  • Loading branch information
solsson committed Jun 27, 2017
1 parent e5ba57e commit 411192d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions 50kafka.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ spec:
prometheus.io/scrape: "true"
prometheus.io/port: "5556"
spec:
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 30
containers:
- name: metrics
image: solsson/kafka-prometheus-jmx-exporter@sha256:1f7c96c287a2dbec1d909cd8f96c0656310239b55a9a90d7fd12c81f384f1f7d
Expand All @@ -35,7 +35,7 @@ spec:
ports:
- containerPort: 9092
command:
- sh
- /bin/bash
- -c
- >
./bin/kafka-server-start.sh
Expand Down
4 changes: 2 additions & 2 deletions zookeeper/50pzoo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
prometheus.io/scrape: "true"
prometheus.io/port: "5556"
spec:
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 30
containers:
- name: metrics
image: solsson/kafka-prometheus-jmx-exporter@sha256:1f7c96c287a2dbec1d909cd8f96c0656310239b55a9a90d7fd12c81f384f1f7d
Expand All @@ -40,7 +40,7 @@ spec:
- name: JMX_PORT
value: "5555"
command:
- sh
- /bin/bash
- -c
- >
set -e;
Expand Down
4 changes: 2 additions & 2 deletions zookeeper/51zoo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
prometheus.io/scrape: "true"
prometheus.io/port: "5556"
spec:
terminationGracePeriodSeconds: 10
terminationGracePeriodSeconds: 30
containers:
- name: metrics
image: solsson/kafka-prometheus-jmx-exporter@sha256:1f7c96c287a2dbec1d909cd8f96c0656310239b55a9a90d7fd12c81f384f1f7d
Expand All @@ -40,7 +40,7 @@ spec:
- name: JMX_PORT
value: "5555"
command:
- sh
- /bin/bash
- -c
- >
set -e;
Expand Down

0 comments on commit 411192d

Please sign in to comment.