Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21724 new general page updating counters properly new #21781

Merged
merged 6 commits into from
Oct 30, 2024
Merged

21724 new general page updating counters properly new #21781

merged 6 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. Add update notification total helper

    @igorschoester @leonidasmi
    igorschoester authored and leonidasmi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    11855a2 View commit details
    Browse the repository at this point in the history

  2. Refactor the admin bar to always render the notification totals 

    Just hiding it when the count is 0.
This simplifies the frontend needed when a user decides to make a notification visible again.
    @igorschoester @leonidasmi
    igorschoester authored and leonidasmi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    27d98d4 View commit details
    Browse the repository at this point in the history

  3. Add notification count sync hook

    @igorschoester @leonidasmi
    igorschoester authored and leonidasmi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c89f9cc View commit details
    Browse the repository at this point in the history

  4. Remove the reindex notification from the FTC

    @igorschoester @leonidasmi
    igorschoester authored and leonidasmi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    16e67d7 View commit details
    Browse the repository at this point in the history

  5. Use named export instead 

    Easier to follow in your IDE
    @igorschoester @leonidasmi
    igorschoester authored and leonidasmi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5cb6245 View commit details
    Browse the repository at this point in the history

  6. Improve test coverage 

    Don't export toggleAlertStatus itself, only via actions objects
    @igorschoester @leonidasmi
    igorschoester authored and leonidasmi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f4d6063 View commit details
    Browse the repository at this point in the history