Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product schema offers declaration description #239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moorscode
Copy link
Contributor

Summary

The described property cannot be a list, but has to be a reference to an offer (or aggregate offer as that is a derivative of an offer).

See the Schema docs for the declaration: https://schema.org/Product

The example also shows an object with an @id instead of a list.

Quality assurance

  • I have altered a filename.
    • I have adjusted the ID property accordingly and updated all internal links.
    • I have added the redirect to the _redirects file in the root of the project.

The described property cannot be a list, but has to be a reference to an offer (or aggregate offer as that is a derivative of an offer).

See the Schema docs for the declaration: https://schema.org/Product

The example also shows an object with an `@id` instead of a list.
@moorscode moorscode closed this Jul 24, 2023
@moorscode moorscode reopened this Jul 24, 2023
@d-claassen
Copy link
Contributor

Hey there @moorscode. Thanks for taking the time to add your contribution! 😃

The schema.org data model is really flexible, and will almost anywhere accept both a single instance or multiple instances in an array. As an example, take a look at the review property on the Product type, which can also take a list of multiple Review instances. In fact, the Schema documentation about Product that you linked has an example (Example 2) showing the property offers with a list of Offer instances. Note this example shows both the property with a single instance and an array of instances, through the AggregateOffer object, but in the Schema data model there's no difference between the two properties depending on their type.

In case you're interested, we'll definitely be open to accepting a contribution to reflect both possibilities are acceptable: Either a reference by ID, or an array of such references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants