Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP logger & UI Changes #29

Merged
merged 13 commits into from
Oct 8, 2023
Merged

HTTP logger & UI Changes #29

merged 13 commits into from
Oct 8, 2023

Conversation

MarkEcza
Copy link
Contributor

@MarkEcza MarkEcza commented Oct 7, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Download the artifacts for this pull request:

@MarkEcza MarkEcza changed the title Add optional network request logger HTTP logger & UI Changes Oct 7, 2023
@MarkEcza
Copy link
Contributor Author

MarkEcza commented Oct 7, 2023

Changed PR's main concept to UI overhaul & improvements.
image

@MarkEcza
Copy link
Contributor Author

MarkEcza commented Oct 7, 2023

Closes #30

@tyackman
Copy link
Contributor

tyackman commented Oct 8, 2023

Styling looks pretty heckin nice imo

src/game/pointers/Pointers.cpp Outdated Show resolved Hide resolved
src/game/frontend/menu/Menu.cpp Show resolved Hide resolved
src/game/frontend/menu/Menu.cpp Outdated Show resolved Hide resolved
src/game/pointers/Pointers.cpp Outdated Show resolved Hide resolved
@MarkEcza
Copy link
Contributor Author

MarkEcza commented Oct 8, 2023

Indents are fucked thanks to github

@maybegreat48
Copy link
Contributor

Indents are fucked thanks to github

That's a feature that intentionally reveals if you've mixed tabs and spaces in a file

@MarkEcza
Copy link
Contributor Author

MarkEcza commented Oct 8, 2023

Indents are fucked thanks to github

That's a feature that intentionally reveals if you've mixed tabs and spaces in a file

image

@maybegreat48
Copy link
Contributor

Indents are fucked thanks to github

That's a feature that intentionally reveals if you've mixed tabs and spaces in a file

image

Most editors do not have that feature

@DayibBaba DayibBaba merged commit 6bde45e into YimMenu:master Oct 8, 2023
1 check passed
@maybegreat48
Copy link
Contributor

@Hydra-Source Can you try to load the menu with the Vulkan renderer?

@MarkEcza
Copy link
Contributor Author

MarkEcza commented Oct 8, 2023

@Hydra-Source Can you try to load the menu with the Vulkan renderer?

Vulkan on AMD is broken at the moment(was always) use DX12 it should be better now and clear your dx cache and try.

@maybegreat48
Copy link
Contributor

maybegreat48 commented Oct 8, 2023

@Hydra-Source Can you try to load the menu with the Vulkan renderer?

Vulkan on AMD is broken at the moment(was always) use DX12 it should be better now and clear your dx cache and try.

It worked fine for me but it now crashes on the font thing (using Nvidia)

use DX12 it should be better now

DX is really broken for me, even without HorseMenu

@MarkEcza
Copy link
Contributor Author

MarkEcza commented Oct 8, 2023

@Hydra-Source Can you try to load the menu with the Vulkan renderer?

Vulkan on AMD is broken at the moment(was always) use DX12 it should be better now and clear your dx cache and try.

It worked fine for me but it now crashes on the font thing (using Nvidia)

Oh really, i couldn't test since i was on AMD but sure thing i'll look into it tonight with my laptop. Thanks for letting me knowing.

@maybegreat48
Copy link
Contributor

I've fixed it in my branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants