Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation - generate readthedocs compatible docs #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drolando
Copy link
Contributor

@jstrfd Sorry, I've been very busy the last few days.

This is the in progress branch I had for adding better docs. It doesn't help you much yet as I haven't written many code samples yet, but I'll try to do it this evening or tomorrow

@jstrfd
Copy link

jstrfd commented Jun 5, 2019

Any updates?

I am reading the comments in py_zipkin source code in zipkin.py, what is the difference between use case 1 and use case 2 in the zipkin span class?

"Usage #2: Trace a service call." VS "Usage #1: Start a trace with a given sampling rate."

@codefromthecrypt
Copy link

@drolando do you know the link for readthedocs off this branch?

@drolando
Copy link
Contributor Author

drolando commented Jun 7, 2019

Yeah sorry I didn't have time to finish this.

So the main point is that the first thing you need to do is to basically initialize the tracer and the transport. That's done by having a zipkin_span which sets a tranport_handler and either a sample_rate or custom zipkin_attrs.
You need to (and should) do this only once, ideally whenever a request arrives at your service or when your batch/script starts.

In all the other places you don't need to do this anymore and you just use zipkin_span(service_name='foo', span_name='bar').

This is kinda confusing which is why I'd like to separate out the tracer from zipkin_span entirely, but since it's a backward incompatible change I haven't done it just yet.

@drolando
Copy link
Contributor Author

drolando commented Jun 7, 2019

@adriancole I couldn't find a way to upload them to readthedocs without merging to master :(

So for now you either read the .rst files or checkout this branch, run make docs, cd docs/build and python -m SimpleHTTPServer 8888.

@jstrfd
Copy link

jstrfd commented Jun 7, 2019

The version is 0.something....make all the things better and change the major version? Simpler is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants