Refactor paasta logs filtering for performance #3988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things.
paasta_*_passes_filter
evaluation logic to be more resource efficient and fast:paasta logs
that retrieves logs from a 5 minutes time range for a verbose stream:As can be seen, new version is twice as fast than older one, mainly because of eliminating frequent and costly
isotime
,isodate
calls.isodate
to the latest as it should include a fix forhttps://github.com/gweis/isodate/issues/53
. Also it would fix currentpaasta logs
crashes from the same bug, e.g. atpaasta/paasta_tools/cli/cmds/logs.py
Line 397 in f65acaf