Add tron topology_spread_constraints support to PaaSTA #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
requested review from
EvanKrall,
jfongatyelp,
EmanElsaban,
ilkinmammadzada and
KaspariK
nemacysts
changed the title
This adds support for configuring Tron-launched pods with a default Topology Spread Constraint (and node affinities) that will spread pods out across multiple AZs - otherwise, Karpenter will overwhelmingly favor a single AZ due to our config
nemacysts
force-pushed
the
luisp/TRON-2213-tsc
branch
from
0934f37
to
31673fc
Compare
|
requires Yelp/Tron#1003 and Yelp/task_processing#220 |
EmanElsaban
reviewed
Oct 28, 2024
paasta_tools/tron_tools.py
Outdated
| # PAASTA-18198: To improve AZ balance with Karpenter, we temporarily allow specifying zone affinities per pool | ||
| pool_node_affinities = load_system_paasta_config().get_pool_node_affinities() | ||
| if pool_node_affinities and self.get_pool() in pool_node_affinities: | ||
| current_pool_node_affinities = pool_node_affinities[self.get_pool()] |
There was a problem hiding this comment.
what does this dictionary/map returns pool_node_affinities[self.get_pool()]?
There was a problem hiding this comment.
is it the config to set the pool node affinities?
There was a problem hiding this comment.
this is a puppet-defined dict (see paasta_tools::public_config::pool_node_affinities internally) that defines a default set of affinities for certain pools (speaking of which, we should probably add an entry for the tron pool :p):
default:
topology.kubernetes.io/zone:
- us-west-2a
- us-west-2b
There was a problem hiding this comment.
ahh i see it returns the azs affinities:
paasta_tools::public_config::pool_node_affinities:
# pnw-prod default should only run on us-west-2a and us-west-2b (unless there's a deploy_whitelist override)
default:
topology.kubernetes.io/zone:
- us-west-2a
- us-west-2b
There was a problem hiding this comment.
ahh sorry just saw your answer, yea makes sense
EmanElsaban
previously approved these changes
Oct 28, 2024
This'll let us deploy this without big-bouncing Tron everywhere
I realized that we weren't consistently using the same mock SystemPaastaConfig - so I went ahead and fixed that while I was here
jfongatyelp
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for configuring Tron-launched pods with a default Topology Spread Constraint (and node affinities) that will spread pods out across multiple AZs - otherwise, Karpenter will overwhelmingly favor a single AZ due to our config
I've double-checked that the feature flag works by running this code on
infrastage as well (as well as with the tests)
NOTE: there's a lot of test "changes", but that's mostly since I noticed
that we were inconsistently mocking load_system_paasta_config() and I wanted
to centralize things to make sure that the tests were doing the right thing.