Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for vscode test parser #3681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cuza
Copy link
Member

@cuza cuza commented Aug 21, 2023

Making VSCode test parser happy

image

@nemacysts
Copy link
Member

@cuza what is the current code doing to make VSCode unhappy? is it crashing or something on creating the spark config?

(i've also CC'd @CaptainSame since they recently touched this code)

@cuza
Copy link
Member Author

cuza commented Aug 21, 2023

@nemacysts

==================================== ERRORS ====================================
______________ ERROR collecting tests/cli/test_cmds_spark_run.py _______________
tests/cli/test_cmds_spark_run.py:513: in <module>
    @mock.patch.object(spark_config.SparkConfBuilder(), "get_history_url", autospec=True)
E   AttributeError: module 'service_configuration_lib.spark_config' has no attribute 'SparkConfBuilder'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 2.02 seconds ============================

nemacysts
nemacysts previously approved these changes Aug 21, 2023
@mattmb
Copy link
Member

mattmb commented Feb 21, 2024

Looks minor so I'll merge if the tests pass in a mo rather than closing

@nemacysts
Copy link
Member

@cuza do we still need/want this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants