Skip to content

Commit

Permalink
Restructure locations of yelp reviews test and util classes (#727)
Browse files Browse the repository at this point in the history
  • Loading branch information
aprudhomme authored Sep 24, 2024
1 parent b384268 commit 7604cc2
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
name: jacoco-report
path: build/reports/jacoco/
- name: Yelp Reviews Perf test
run: ./gradlew clean installDist :test -PincludePerfTests=* --tests "com.yelp.nrtsearch.server.YelpReviewsTest.runYelpReviews" --info
run: ./gradlew clean installDist :test -PincludePerfTests=* --tests "com.yelp.nrtsearch.yelp_reviews.YelpReviewsTest.runYelpReviews" --info
- name: Merge behavior tests
run: ./gradlew clean installDist :test -PincludePerfTests=* --tests "com.yelp.nrtsearch.server.grpc.MergeBehaviorTests" --info
- name: Long running tests
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -159,5 +159,5 @@ This should create a src/main/docs/index.html file that can be seen in your loca
This tool indexes yelp reviews available at [Yelp dataset challenge](https://www.yelp.com/dataset). It runs a default version with only 1k reviews of the `reviews.json` or you could download the yelp dataset and place the review.json in the user.home dir and the tool will use that instead. The complete review.json should have close to 7Million reviews. The tool runs multi-threaded indexing and a search thread in parallel reporting the `totalHits`. Command to run this specific test:

```
./gradlew clean installDist :test -PincludePerfTests=* --tests "com.yelp.nrtsearch.server.YelpReviewsTest.runYelpReviews" --info
./gradlew clean installDist :test -PincludePerfTests=* --tests "com.yelp.nrtsearch.yelp_reviews.YelpReviewsTest.runYelpReviews" --info
```
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.yelp.nrtsearch.server;
package com.yelp.nrtsearch.yelp_reviews;

import com.google.gson.Gson;
import com.google.protobuf.InvalidProtocolBufferException;
Expand All @@ -40,8 +40,8 @@
import com.yelp.nrtsearch.server.grpc.StartIndexRequest;
import com.yelp.nrtsearch.server.grpc.StartIndexResponse;
import com.yelp.nrtsearch.server.grpc.TransferStatusCode;
import com.yelp.nrtsearch.server.utils.OneDocBuilder;
import com.yelp.nrtsearch.server.utils.ParallelDocumentIndexer;
import com.yelp.nrtsearch.yelp_reviews.utils.OneDocBuilder;
import com.yelp.nrtsearch.yelp_reviews.utils.ParallelDocumentIndexer;
import io.grpc.Status;
import io.grpc.StatusRuntimeException;
import java.io.File;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.yelp.nrtsearch.server.utils;
package com.yelp.nrtsearch.yelp_reviews.utils;

import com.google.gson.Gson;
import com.yelp.nrtsearch.server.grpc.AddDocumentRequest;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.yelp.nrtsearch.server.utils;
package com.yelp.nrtsearch.yelp_reviews.utils;

import com.yelp.nrtsearch.server.grpc.AddDocumentRequest;
import com.yelp.nrtsearch.server.grpc.AddDocumentResponse;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.yelp.nrtsearch.server.utils;
package com.yelp.nrtsearch.yelp_reviews.utils;

import com.google.gson.Gson;
import com.yelp.nrtsearch.server.grpc.AddDocumentRequest;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.yelp.nrtsearch.server.utils;
package com.yelp.nrtsearch.yelp_reviews.utils;

import com.yelp.nrtsearch.server.grpc.LuceneServerClient;
import java.io.BufferedReader;
Expand Down

0 comments on commit 7604cc2

Please sign in to comment.