Backport: Allow whitespace in mappingV2 rules (#781)

Yelp · Nov 6, 2024 · 546f040 · 546f040
1 parent 07ce943
commit 546f040
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/...main/java/com/yelp/nrtsearch/server/luceneserver/analysis/MappingV2CharFilterFactory.java b/...main/java/com/yelp/nrtsearch/server/luceneserver/analysis/MappingV2CharFilterFactory.java
@@ -91,7 +91,7 @@ private List<String> extractRules(String mappings, String separator) {
     return Arrays.asList(mappings.split(separator));
   }
 
-  static Pattern p = Pattern.compile("(.*)\\s*=>\\s*(.*)\\s*$");
+  static Pattern p = Pattern.compile("(.*)=>(.*)$");
 
   protected void parseRules(List<String> rules, NormalizeCharMap.Builder builder) {
     for (String rule : rules) {

diff --git a/.../java/com/yelp/nrtsearch/server/luceneserver/analysis/MappingV2CharFilterFactoryTest.java b/.../java/com/yelp/nrtsearch/server/luceneserver/analysis/MappingV2CharFilterFactoryTest.java
@@ -54,6 +54,13 @@ public void testDifferentSeparator() throws IOException {
     assertEquals("abc and d n e'n'f g hi", output);
   }
 
+  @Test
+  public void testWhitespaceInRule() throws IOException {
+    MappingV2CharFilterFactory factory = getFactory(". =>|,=> ");
+    String output = getFiltered(factory, "this. is, a test, string");
+    assertEquals("thisis  a test  string", output);
+  }
+
   @Test
   public void testNoMappings() {
     try {