Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade to known working requests version #79

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

kentwills
Copy link
Contributor

Downgraded to version of requests we use internally. Reports of this version not working in production. Need to further investigate.

@kentwills kentwills requested a review from bxm156 April 16, 2017 22:37
@kentwills kentwills self-assigned this Apr 16, 2017
@kentwills kentwills requested a review from ajm188 April 17, 2017 15:29
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, but okay

@ajm188
Copy link
Contributor

ajm188 commented Apr 17, 2017

@kentwills can we get an issue open to track the issue with requests?

@kentwills
Copy link
Contributor Author

@ajm188 yup just need to take the time to repro on this machine, will do that before pushing this.

@kentwills
Copy link
Contributor Author

@ajm188 well can't repro that one. It was a problem with google app engine before, which was especially tricky because it didn't reproduce unless you were on prod. Discarding.

@kentwills kentwills closed this Apr 18, 2017
@kentwills kentwills reopened this Apr 24, 2017
@kentwills
Copy link
Contributor Author

@ajm188 relates to #83

@ajm188
Copy link
Contributor

ajm188 commented Apr 25, 2017

Yeah I figured as much when I saw the traceback in that issue. Go ahead and merge this then :)

@kentwills kentwills merged commit 9fdbdde into Yelp:master Apr 25, 2017
@kentwills kentwills deleted the downgrade_requests branch May 13, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants