-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A quick script to check if a job took longer than x time to run and update python in precommit #930
Open
EmanElsaban
wants to merge
3
commits into
master
Choose a base branch
from
u/emanelsabban/quick-script-to-check-jobs-running
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,86 @@ | ||||||
#!/usr/bin/env python3.8 | ||||||
import argparse | ||||||
import logging | ||||||
import sys | ||||||
from typing import Optional | ||||||
|
||||||
import pytimeparse | ||||||
|
||||||
from tron.commands import cmd_utils | ||||||
from tron.commands.client import Client | ||||||
|
||||||
|
||||||
log = logging.getLogger("check_exceeding_time") | ||||||
|
||||||
STATES_TO_CHECK = {"queued", "scheduled", "cancelled", "skipped"} | ||||||
|
||||||
|
||||||
def parse_args() -> argparse.Namespace: | ||||||
parser = cmd_utils.build_option_parser() | ||||||
parser.add_argument( | ||||||
"--job", | ||||||
default=None, | ||||||
help="Check if a particular job exceeded a time to run. If unset checks all jobs", | ||||||
) | ||||||
parser.add_argument( | ||||||
"--time", | ||||||
help="This is used to specify the time that if any job exceeds will show. Defaults to 5 hours", | ||||||
type=int, | ||||||
dest="time_limit", | ||||||
default=18000, | ||||||
) | ||||||
args = parser.parse_args() | ||||||
return args | ||||||
|
||||||
|
||||||
def check_if_time_exceeded(job_runs, job_expected_runtime) -> list: | ||||||
result = [] | ||||||
for job_run in job_runs: | ||||||
if job_run.get("state", "unknown") not in STATES_TO_CHECK: | ||||||
if is_job_run_exceeding_expected_runtime( | ||||||
job_run, | ||||||
job_expected_runtime, | ||||||
): | ||||||
result.append(job_run["id"]) | ||||||
return result | ||||||
|
||||||
|
||||||
def is_job_run_exceeding_expected_runtime(job_run, job_expected_runtime) -> bool: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if job_expected_runtime is not None: | ||||||
duration_seconds = pytimeparse.parse(job_run.get("duration", "")) | ||||||
return duration_seconds and duration_seconds > job_expected_runtime | ||||||
return False | ||||||
|
||||||
|
||||||
def check_job_time(job, time_limit) -> list: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
job_runs = job.get("runs", []) | ||||||
return check_if_time_exceeded(job_runs, time_limit) | ||||||
|
||||||
|
||||||
def main() -> Optional[int]: | ||||||
args = parse_args() | ||||||
cmd_utils.setup_logging(args) | ||||||
cmd_utils.load_config(args) | ||||||
client = Client(args.server, args.cluster_name) | ||||||
results = [] | ||||||
|
||||||
if args.job is None: | ||||||
jobs = client.jobs(include_job_runs=True) | ||||||
for job in jobs: | ||||||
job_url = client.get_url(job["name"]) | ||||||
job = client.job_runs(job_url) | ||||||
results.extend(check_job_time(job=job, time_limit=args.time_limit)) | ||||||
else: | ||||||
job_url = client.get_url(args.job) | ||||||
job = client.job_runs(job_url) | ||||||
results.extend(check_job_time(job=job, time_limit=args.time_limit)) | ||||||
|
||||||
if not results: | ||||||
print("All jobs ran within the time limit") | ||||||
else: | ||||||
print(f"These are the runs that took longer than {args.time_limit} to run: {sorted(results)}") | ||||||
return | ||||||
|
||||||
|
||||||
if __name__ == "__main__": | ||||||
sys.exit(main()) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm sort of guessing about the
job_runs
typing here - that said, if we're just using this script for the current project it's probably fine to be a little lax with the types and just do the easy ones (e.g.,