Fix item assignment issue with ConfigSecretVolume #924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the schema assumption that configsecretVolume's "items" field is an array. I did not find the source of the array to tuple transformation, but this is the only place in the code that assume it's a writable array, so this also resolve the problem.
This test job was used with a locally modified version of tron in infrastage.
BEFORE change: https://fluffy.yelpcorp.com/i/7h1Tdwvblkf4KKKxz74V4T83XSbDxfsL.html
run successfully on infrastage: https://fluffy.yelpcorp.com/i/RWBcgXWqVfcsrFVXf9rtwfN6B9N7RpT4.html
retries successfully on infrastage: https://fluffy.yelpcorp.com/i/0d9hRM3hQ3KWv0nSDcHtTKGDLK7phXpt.html
The (currently) failing itest is also present for working commits in master. I don't know what this is about.