remove scripts dir, fix hook (NetApp#423)

* remove scripts dir, fix hook

* fix hook

* one more fix for bsd systems

* don't autofix, fail

* add a .git/hooks target

Makefile

@@ -204,11 +204,15 @@ k8s_codegen:
 k8s_codegen_operator:
 	cd operator && $(MAKE) k8s_codegen
 
+.git/hooks:
+	mkdir -p $@ 
+
+.PHONY: install-lint lint-precommit lint-prepush
 install-lint:
 	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin ${GOLANGCI-LINT_VERSION}
 
-lint-precommit: install-lint
+lint-precommit: .git/hooks install-lint
 	cp hooks/golangci-lint.sh .git/hooks/pre-commit
 
-lint-prepush: install-lint .git/hooks/pre-push
+lint-prepush: .git/hooks install-lint .git/hooks/pre-push
 	cp hooks/golangci-lint.sh .git/hooks/pre-push

hooks/golangci-lint.sh

@@ -1,18 +1,19 @@
 #!/bin/sh
 
 # find staged files that end in .go
-STAGED_GO_FILES=$(git diff --cached --name-only | grep ".go$")
+STAGED_GO_DIRS=$(git diff --cached --name-only | grep ".go$" | xargs dirname)
+GO_PACKAGE_DIRS=($(echo "${STAGED_GO_DIRS}" | tr ' ' '\n' | sort -u | tr '\n' ' '))
 
 # if nothing, don't lint. hook successful.
-if [ "$STAGED_GO_FILES" = "" ]; then
+if [ "$STAGED_GO_DIRS" = "" ]; then
   exit 0
 fi
 
 PASS=true
-for FILE in $STAGED_GO_FILES
+for DIR in $GO_PACKAGE_DIRS
 do
     # This is where we will be testing each of our files.
-    golangci-lint run -E goimports --fix $FILE
+    golangci-lint run -E goimports $DIR
 	if [ $? != 0 ]; then
 		PASS=false
 	fi