Makefile: Only save build image for trident_build

When using CREATE_BASE_IMAGE env variable, we want to save the compilation image for the trident orchestrator binary. We do not care about tridentctl or chwrap.
YeYoot · May 31, 2022 · 36f0bc2 · 36f0bc2
1 parent 8e3ed35
commit 36f0bc2
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -117,14 +117,8 @@ ifdef CREATE_BASE_IMAGE
 endif
 	@docker rm ${BUILD_CONTAINER_NAME}
 	@${GO_LINUX} ${BUILD} -ldflags $(BUILD_FLAGS) -o ${TRIDENT_VOLUME_PATH}/bin/${CLI_BIN} ${CLI_PKG}
-ifdef CREATE_BASE_IMAGE
-	@docker commit ${BUILD_CONTAINER_NAME} ${CREATE_BASE_IMAGE}
-endif
 	@docker rm ${BUILD_CONTAINER_NAME}
 	@${GO_LINUX} ${BUILD} -ldflags $(BUILD_FLAGS) -o ${TRIDENT_VOLUME_PATH}/bin/chwrap chwrap/chwrap.go
-ifdef CREATE_BASE_IMAGE
-	@docker commit ${BUILD_CONTAINER_NAME} ${CREATE_BASE_IMAGE}
-endif
 	@docker rm ${BUILD_CONTAINER_NAME}
 	cp ${BIN_DIR}/${BIN} ${BIN_DIR}/${CLI_BIN} .
 	chwrap/make-tarball.sh ${BIN_DIR}/chwrap chwrap.tar