Squash bugs - autoRefreshPage in particular is critical. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoRefreshPage - global variable names have changed. useAutoBadgePurchase - abilityPriorityList in wrong scope setPreference, setPreference - missing "typeof" useAbilities - enemySpawnerHealthPercent is initialized to bool instead of number
|
The only thing sitting a little off with me, and it may just be the lack of sleep, is the use of var on abilityPriorityList multiple times in the same function. Don't you only have to declare it once? |
|
The variable name corrects should go out as soon as possible. Can you drop the vars on abilityPriorityList and make it a separate pull request? |
| @@ -719,12 +717,11 @@ function useAutoBadgePurchase() { | |||
| //Note: this isn't an actual ratio, because badge points get reduced and the values don't add to 1 | |||
| //For now, this is not a problem, but for stylistic reasons, should eventually be changed. | |||
|
|
|||
| //Regular users buy ratio | |||
|
|
|||
| var abilityPriorityList = [] | |||
|
Hi. It's the old version that has multiple vars of abilityPriorityList, not my new one. Anyway, I'm very new to Git.. I had to delete my old repository because I had mad changes that I didn't intend to send a pull request because I didn't know of a better way... BTW; Sorry about spamming those line comments.. I didn't know it would get shown here. Just as well maybe, since I forgot to mention them. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoRefreshPage - global variable names have changed. Would probably make browsers stop refreshing
useAutoBadgePurchase - abilityPriorityList in wrong scope
setPreference, setPreference - missing "typeof"
useAbilities - enemySpawnerHealthPercent is initialized to bool instead of number