Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add critical tv smacking feature back in #59

Closed
wants to merge 1 commit into from

Conversation

hlfbt
Copy link

@hlfbt hlfbt commented Jun 21, 2015

importance: verily

Made Honking persist through a refresh

Can't stop the Honk!

Honking Intenstifys

Updated version to 7.1.2

Fixed a div check

Fixed up a wronky if

Smack from a better angle

revert version

revert version

Revert "Merge pull request #1 from GoomiChan/Honking-Intensifies"

This reverts commit a86c618, reversing
changes made to 118d491.
@Novex
Copy link
Member

Novex commented Jun 21, 2015

I have no idea what this is meant to do?

@DannyDaemonic
Copy link

I don't get the reference to "smack tv", and I hate seeing the words there, but this is actually kind of cool. The canvas (tv screen) has a filter on it to make it look like there are scanlines. This makes it so when you click the little steam logo it changes that filter. It has a couple different effects you can cycle through.

@DannyDaemonic
Copy link

Although this patch doesn't seem to contain that code. I think maybe tubersan submitted the wrong patch, or the reversions have confused git's diff.

@DannyDaemonic
Copy link

Sorry, but something seems to have screwed up your pull request? I put part of it back. If you intended on adding anything else that I missed please open a new pull request.

@hlfbt
Copy link
Author

hlfbt commented Jun 21, 2015

Mmh, I had changed the code so that the Smack TV words are next to the TV and not on the little steam logo anymore, it should look something like this: https://i.nope.bz/05XK.png (notice the "Smack TV" on the left and right of the screen)
Should I submit another PR that puts the button/link for smacking in that place instead of where it is now?

edit:
Here's a new one yet again: #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants