Monty/character export #1426
Merged
Monty/character export #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the merged in rust-g#1 to provide a button on the character setup screen that allows players to export their entire player save, including user preferences and all character slots, to a JSON file which they can then download.
Included in this PR are the compiled rust-g binaries for both platforms from the above linked repo, as well as the new
rust_g_yw.dmfile it creates so as not to mess with upstream's custom handwrittenrust_g.dm.This implementation creates no temp files on the host disk, it's all handled by a dynamic javascript blob, so there shouldn't be any issues with filesystem security on that end.
Incidentally it also led to the creation of a breakout
code/modules/client/preferences_yw.dmto house this change and future additions to the core preferences file.Player confirmation dialog:
Internet Explorer download windows:
The backup window that allows people to copy-paste their save in case the auto download fails:
