Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bevy to v0.11 #156

Merged
merged 24 commits into from
Aug 16, 2023
Merged

Update Bevy to v0.11 #156

merged 24 commits into from
Aug 16, 2023

Conversation

TimJentzsch
Copy link
Collaborator

Closes #155.

This PR updates to the latest Bevy version, v0.11.

This is still a work in progress, I believe we also have to wait for updates to our dependencies to be released, such as seldom_fn_plugin.

@TimJentzsch TimJentzsch added Bevy plugin dependencies Pull requests that update a dependency file labels Jul 15, 2023
@janhohenheim
Copy link
Member

Thanks for the PR! I was away for vacations, so I'll check in later this week :)

@TimJentzsch
Copy link
Collaborator Author

Shrödingers import, existing and missing at the same time:
Screenshot of a Rustc error, complaining about a missing import. The same import is said to be unused in the next Rustc warning.

@TimJentzsch
Copy link
Collaborator Author

This took longer than expected, but should be ready to review now!

@TimJentzsch TimJentzsch marked this pull request as ready for review August 6, 2023 18:07
crates/core/src/operator.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mafii Mafii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far - @janhohenheim should look over it however, I don't feel 100% confident in my knowledge ;)

crates/example_dialogue_view/src/setup.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mafii Mafii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good for me, I'll shoot @janhohenheim a message if he can take a look! :)

@janhohenheim
Copy link
Member

Sorry for the delay! LGTM, thanks for the work! :)

@janhohenheim janhohenheim merged commit 67ce061 into main Aug 16, 2023
6 checks passed
@janhohenheim janhohenheim deleted the 155-bevy-v0.11 branch August 16, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bevy plugin dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bevy plugin to 0.11
3 participants