Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Keep expand fieldref modifier as is #33

Merged
merged 3 commits into from
Dec 28, 2024
Merged

feat: Keep expand fieldref modifier as is #33

merged 3 commits into from
Dec 28, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Dec 26, 2024 •
edited
Loading

What Changed

Test

fukusuke@fukusukenoMacBook-Air sigma-to-hayabusa-converter % diff -qr converted_sigma_rules_new converted_sigma_rules_old 
Only in converted_sigma_rules_new/builtin: placeholder
Files converted_sigma_rules_new/sysmon/file/file_delete/file_delete_win_delete_own_image.yml and converted_sigma_rules_old/sysmon/file/file_delete/file_delete_win_delete_own_image.yml differ
Only in converted_sigma_rules_new/sysmon: placeholder

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket self-assigned this Dec 26, 2024
@fukusuket fukusuket added the enhancement New feature or request label Dec 26, 2024
@fukusuket fukusuket marked this pull request as ready for review December 26, 2024 15:04
@fukusuket fukusuket mentioned this pull request Dec 26, 2024
Merged
@fukusuket
Copy link
Collaborator Author

fukusuket commented Dec 26, 2024 •
edited
Loading

@YamatoSecurity
Sorry... The following bug is causing a parse error,

it would be better to merge the version that fixes A after the release :(

@fukusuket fukusuket marked this pull request as draft December 26, 2024 21:46
@YamatoSecurity YamatoSecurity marked this pull request as ready for review December 28, 2024 05:18
@YamatoSecurity YamatoSecurity self-requested a review December 28, 2024 05:19
YamatoSecurity
YamatoSecurity approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thank you!

@YamatoSecurity YamatoSecurity merged commit c66cc4c into main Dec 28, 2024
@YamatoSecurity YamatoSecurity deleted the enable-expand-fieldref branch December 28, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

Assignees

@fukusuket fukusuket

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep expand rules Keep fieldref modifiers as-as (Dec. 2024)
2 participants
@fukusuket @YamatoSecurity