-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Temporal Proximity correlation #1532
Conversation
diff checkResulting files are the same size before and after This PR.
|
Temporal ruleI confirmed that temporal rule can be detected in following simple case. title: Correlation Test Rule
id: 23179f25-6fce-4827-bae1-b219deaf563a
author: fukusuket
correlation:
type: temporal
rules:
- failed_logins
- successful_login
group-by:
- Computer
timespan: 1m
generate: true
level: critical
ruletype: Hayabusa
---
id: 23179f25-6fce-4827-bae1-b219deaf563c
title: Failed Logins
name: failed_logins
logsource:
product: windows
service: security
detection:
selection:
Channel: Security
EventID: 4625
LogonType: 2
condition: selection
---
id: 23179f25-6fce-4827-bae1-b219deaf563x
title: Successful Login
name: successful_login
logsource:
product: windows
service: security
detection:
selection:
Channel: Security
EventID: 4624
LogonType: 2
condition: selection
following records detected by temporal rule.
|
@fukusuket Thanks so much! When
under the Could you check this? |
@YamatoSecurity
|
@fukusuket Thanks! There seems to be a bug with the author name being overwritten.
there should be
Could you check this? |
@YamatoSecurity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket LGTM! Thanks so much!!!
What Changed
Evidence
Integration-Test
I would appreciate it if you could check it out when you have time🙏