Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize 2.18.0 #1458

Merged
merged 3 commits into from
Oct 22, 2024
Merged

finalize 2.18.0 #1458

merged 3 commits into from
Oct 22, 2024

Conversation

YamatoSecurity
Copy link
Collaborator

updated crates for the next release

@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Oct 21, 2024
@YamatoSecurity YamatoSecurity added this to the 2.18.0 Sector Release milestone Oct 21, 2024
@YamatoSecurity YamatoSecurity self-assigned this Oct 21, 2024
@YamatoSecurity
Copy link
Collaborator Author

@fukusuket It looks like some of our tests are failing because we removed the sample files? Could you take a look at this?

@fukusuket
Copy link
Collaborator

fukusuket commented Oct 21, 2024

@YamatoSecurity
With the Rust version upgrade, Clippy's checks seem to have become stricter. I will fix this later!

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀 I fixed clippy error and test error!

@YamatoSecurity
Copy link
Collaborator Author

@fukusuket Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 11d1813 into main Oct 22, 2024
9 of 10 checks passed
@YamatoSecurity YamatoSecurity deleted the finalize-2.18.0 branch October 22, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants