Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted output numbers #1310

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Formatted output numbers #1310

merged 1 commit into from
Mar 15, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Formatted output numbers

Evidence

image

@hitenkoku hitenkoku added the enhancement New feature or request label Mar 15, 2024
@hitenkoku hitenkoku self-assigned this Mar 15, 2024
@hitenkoku hitenkoku linked an issue Mar 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 27.65957% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 81.02%. Comparing base (780422f) to head (b3f8615).

Files Patch % Lines
src/main.rs 10.81% 33 Missing ⚠️
src/detections/detection.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
- Coverage   81.08%   81.02%   -0.07%     
==========================================
  Files          27       27              
  Lines       24680    24706      +26     
==========================================
+ Hits        20012    20017       +5     
- Misses       4668     4689      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hitenkoku hitenkoku requested a review from fukusuket March 15, 2024 03:41
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thank you!

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

@hitenkoku hitenkoku merged commit 91c8cf5 into main Mar 15, 2024
9 checks passed
@hitenkoku hitenkoku deleted the 1308-output-numbers-with-commas branch March 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output numbers with commas
3 participants