Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for using Vulkan-Hpp C++20 module #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

qbojj
Copy link

@qbojj qbojj commented Jul 10, 2024

Closes: #33

I have found a way to add support for pulling vulkan-hpp as a module.

I have also changed CMakeLists to test this solution.

VMA_BUILD_CXX_MODULE builds the module and VMA_BUILD_WITH_VULKAN_MODULE uses vulkan module as a dependency.

As Vulkan-Hpp (or CMake) is yet to supply a stable module installation, those changes are not meant to be installed but to showcase the usage.

@qbojj qbojj marked this pull request as draft July 10, 2024 14:42
@qbojj
Copy link
Author

qbojj commented Jul 10, 2024

There are currently 2 problems:

I will see what is happening with the second case when the first part gets fixed

@qbojj qbojj marked this pull request as ready for review July 28, 2024 22:52
@qbojj
Copy link
Author

qbojj commented Jul 28, 2024

As it is planned to totally remove vk::detail:: from c++ module (KhronosGroup/Vulkan-Hpp#1931) i have pulled the required functions into this repo. The worst part of it is throwResultException but we could strip it of any error codes that are not going to be returned from VMA, but for now I have just pulled the current implementation.

Also currently getDispatchLoaderStatic is not exported and it looks like it may also be pulled into the detail (KhronosGroup/Vulkan-Hpp#1927). As such I have removed the only instance of project (potentially) referencing it: default parameter of functionsFromDispatcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make c++20 module use vulkan_hpp module
1 participant